srowen commented on a change in pull request #24230: [SPARK-27295][GraphX]
Provision to provide the initial scores for source nodes while running
Personalized Page Rank
URL: https://github.com/apache/spark/pull/24230#discussion_r272092789
##########
File path:
graphx/src/test/scala/org/apache/spark/graphx/lib/PageRankSuite.scala
##########
@@ -115,7 +115,7 @@ class PageRankSuite extends SparkFunSuite with
LocalSparkContext {
assert(compareRanks(staticRanks, dynamicRanks) < errorTol)
val parallelStaticRanks = starGraph
- .staticParallelPersonalizedPageRank(Array(0), numIter,
resetProb).mapVertices {
+ .staticParallelPersonalizedPageRank(Array((0, 1.0)), numIter,
resetProb).mapVertices {
Review comment:
I suppose you aren't testing that the implementation correctly passes the
initial scores and uses them, nor testing that the original method that causes
1 to be the default works now (unless some tests still cover this). There's no
reason to make elaborate tests, but is there any simple test case you can
copy/paste that shows the result is different and basically correct with
initial scores that aren't 1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
