Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/3726#issuecomment-68025072
Eventually is pretty much trying a test in a loop and that encourages
flakey tests - I am in general not a very big fan of using eventually.
The correct approach is to fix the non-determinism. Being able to detect
that all files have been deleted has value - and gives easy debuggability.
Being able to deterministically to know that all files are gone before
proceeding does help debuggability.
I don't really believe we are actually a accommodating the test - we are
really fixing the code to allow deterministic testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
