vanzin commented on a change in pull request #24303: [SPARK-27394][WebUI]Flush
LiveEntity if necessary when receiving SparkListenerExecutorMetricsUpdate
URL: https://github.com/apache/spark/pull/24303#discussion_r272410515
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -831,6 +835,14 @@ private[spark] class AppStatusListener(
}
}
}
+ // Flush updates if necessary. Executor heartbeat is an event that happens
periodically. Flush
+ // here to ensure the staleness of Spark UI doesn't last more that the
executor heartbeat
+ // interval.
+ if (now - lastFlushTimeNs > liveUpdatePeriodNs) {
+ flush(maybeUpdate(_, now))
Review comment:
If the goal is to use the hearbeats as some trigger for flushing, how about
using some ratio of the heartbeat period instead of `liveUpdatePeriodNs` to
control whether to flush everything?
Really large apps can get a little backed up when processing hearbeats from
lots and lots of busy executors, and this would make it a little worse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
