BryanCutler commented on a change in pull request #24070: [SPARK-23961][PYTHON]
Fix error when toLocalIterator goes out of scope
URL: https://github.com/apache/spark/pull/24070#discussion_r272411139
##########
File path: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
##########
@@ -168,7 +168,32 @@ private[spark] object PythonRDD extends Logging {
}
def toLocalIteratorAndServe[T](rdd: RDD[T]): Array[Any] = {
- serveIterator(rdd.toLocalIterator, s"serve toLocalIterator")
+ val (port, secret) = SocketAuthServer.setupOneConnectionServer(
+ authHelper, "serve toLocalIterator") { s =>
+ val out = new DataOutputStream(s.getOutputStream)
+ val in = new DataInputStream(s.getInputStream)
+ Utils.tryWithSafeFinally {
+
+ // Collects a partition on each iteration
+ val collectPartitionIter = rdd.partitions.indices.iterator.map { i =>
+ rdd.sparkContext.runJob(rdd, (iter: Iterator[Any]) => iter.toArray,
Seq(i)).head
Review comment:
Yeah, that would have better performance, but it does say in the doc that
max memory usage will be the largest partition. Going over that might cause
problems for some people, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
