Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3778#issuecomment-68029380
@scwf These optimizations are useful, particularly the one that eliminates
common predicates. Thanks for bringing them up! However, the implementation in
this PR is really over complicated... I opened #3784 for a simpler version.
For the numeric comparisons, I think we can first cast all numeric
comparisons to `Double` type and derive a `Double` range from each predicate
and then eliminate unnecessary comparisons by comparing ranges. `Double` is
preferred because `Double.PositiveInfinity` and `Double.NegativeInfinity` can
be handy when dealing with predicates like `a < 10` and `a > 100`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
