Github user dbtsai commented on the pull request:

    https://github.com/apache/spark/pull/1379#issuecomment-68029618
  
    @avulanov It's very encouraging benchmark result you saw in real world 
cluster setup. Since I'm on vacation recently, I don't actually deploy the new 
code and benchmark in our cluster. Great to see such huge 10x performance gain 
(actually bigger than what I thought, and in my local single machine testing, I 
only saw 2~4x difference.)
    
    What optimization do you do on your ANN implementation? The same things in 
MLOR?
    
    @mengxr Is it possible to reopne this closed PR in github? There are lots 
of useful discussion here, so I don't want to open another PR in github. I 
think I'm mostly done except the unit-test, and I can push the code for code 
review now before our meeting. (PS, the now code is more generalized than 
binary one, and has the same performance in the binary special case in my local 
testing.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to