ueshin commented on a change in pull request #24298: [SPARK-27276][PYTHON][SQL]
Increase minimum version of pyarrow to 0.12.1 and remove prior workarounds
URL: https://github.com/apache/spark/pull/24298#discussion_r272425920
##########
File path: python/pyspark/serializers.py
##########
@@ -289,7 +291,6 @@ def _create_batch(self, series):
def create_array(s, t):
mask = s.isnull()
# Ensure timestamp series are in expected form for Spark internal
representation
- # TODO: maybe don't need None check anymore as of Arrow 0.9.1
if t is not None and pa.types.is_timestamp(t):
s = _check_series_convert_timestamps_internal(s.fillna(0),
self._timezone)
# TODO: need cast after Arrow conversion, ns values cause
error with pandas 0.19.2
Review comment:
Do we still need the workaround `.from_pandas` .. `.cast` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
