cloud-fan commented on a change in pull request #24129: [SPARK-27190][SQL] add
table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r272429913
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/WriteBuilder.java
##########
@@ -70,6 +71,12 @@ default BatchWrite buildForBatch() {
" does not support batch write");
}
+ /**
+ * Returns a {@link StreamingWrite} to write data to streaming source. By
default this method
+ * throws exception, data sources must overwrite this method to provide an
implementation, if the
+ * {@link Table} that creates this write returns {@link
TableCapability#STREAMING_WRITE} support
+ * in its {@link Table#capabilities()}.
+ */
Review comment:
You did the same when you add the batch read/write capability, didn't you?
`TableCapability#STREAMING_WRITE` is added in this PR and I have to add related
document at the places that need to mention it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]