LantaoJin commented on issue #24245: [SPARK-13704][CORE][YARN] Reduce rack resolution time URL: https://github.com/apache/spark/pull/24245#issuecomment-480133850 > Looks fine. I still think that `getRackForHosts` could just return a `Seq[String]` and avoid using `Option` at all - the code in `SparkRackResolver` doesn't seem to ever return a `null` location, but not worth delaying this patch more. That's because if `getRacksForHosts` return Seq[String], `getRackForHost` will return a String. If it is like this, the default value of rack will be difficult to set. `None` is the best one.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
