gengliangwang commented on a change in pull request #24303:
[SPARK-27394][WebUI]Flush LiveEntity if necessary when receiving
SparkListenerExecutorMetricsUpdate
URL: https://github.com/apache/spark/pull/24303#discussion_r272449472
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -831,6 +835,14 @@ private[spark] class AppStatusListener(
}
}
}
+ // Flush updates if necessary. Executor heartbeat is an event that happens
periodically. Flush
+ // here to ensure the staleness of Spark UI doesn't last more that the
executor heartbeat
+ // interval.
+ if (now - lastFlushTimeNs > liveUpdatePeriodNs) {
+ flush(maybeUpdate(_, now))
Review comment:
The update only happens in live UI, which should be fine in general. For
real large apps, will it help by setting `LIVE_ENTITY_UPDATE_PERIOD` to a
larger value? Setting a ratio of heartbeat period seems a bit complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
