rdblue commented on a change in pull request #24129: [SPARK-27190][SQL] add
table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r272653909
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/WriteBuilder.java
##########
@@ -70,6 +71,12 @@ default BatchWrite buildForBatch() {
" does not support batch write");
}
+ /**
+ * Returns a {@link StreamingWrite} to write data to streaming source. By
default this method
+ * throws exception, data sources must overwrite this method to provide an
implementation, if the
+ * {@link Table} that creates this write returns {@link
TableCapability#STREAMING_WRITE} support
+ * in its {@link Table#capabilities()}.
+ */
Review comment:
I don't see any changes in the [read/write capability
PR](https://github.com/apache/spark/pull/24012/files) that changed unrelated
files with only documentation, unless the previous version had links to classes
that were deleted. You were right that the changes to `Scan` are needed because
the links would otherwise break and that PR made a similar change.
But the change here and the change to `Table` are not required and should be
done in documentation PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
