rdblue commented on a change in pull request #24233: [SPARK-26356][SQL] remove
SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r272766335
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopSuite.scala
##########
@@ -54,7 +56,7 @@ class NoopSuite extends SharedSQLContext {
accum.add(1)
x
}
- .write.format("noop").save()
+ .write.format("noop").mode("append").save()
Review comment:
The proposal is only to change the default when using v2. If we don't change
the default for v2, then the default is to always fail, which I think is worse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
