dongjoon-hyun commented on a change in pull request #24308: [SPARK-27397][Core]
Take care of OpenJ9 JVM in Spark
URL: https://github.com/apache/spark/pull/24308#discussion_r272805159
##########
File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
##########
@@ -131,8 +131,9 @@ object SizeEstimator extends Logging {
return System.getProperty(TEST_USE_COMPRESSED_OOPS_KEY).toBoolean
}
- // java.vm.info provides compressed ref info for IBM JDKs
- if (System.getProperty("java.vendor").contains("IBM")) {
+ // java.vm.info provides compressed ref info for IBM and OpenJ9 JDKs
+ if (System.getProperty("java.vendor").contains("IBM") ||
Review comment:
If so, it would be great if you mention explicitly the reason for the
following functions.
- `inferDefaultMemory` is not following `IBM` way.
- `getKrb5LoginModuleName` is not following `IBM` way.
Currently, the following statement in the PR description seems to give us
the opposite idea.
```
In other places where see System.getProperty("java.vendor"), we can leave
alone.
```
Thasnk!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
