Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3787#discussion_r22249225
  
    --- Diff: docs/building-spark.md ---
    @@ -60,20 +60,29 @@ mvn -Dhadoop.version=2.0.0-mr1-cdh4.2.0 -DskipTests 
clean package
     mvn -Phadoop-0.23 -Dhadoop.version=0.23.7 -DskipTests clean package
     {% endhighlight %}
     
    -For Apache Hadoop 2.x, 0.23.x, Cloudera CDH, and other Hadoop versions 
with YARN, you can enable the "yarn" profile and optionally set the 
"yarn.version" property if it is different from "hadoop.version". As of Spark 
1.3, Spark only supports YARN versions 2.2.0 and later.
    +For Apache Hadoop 2.2.0 and later and Cloudera CDH 5 with YARN, you can 
enable the "yarn" profile and optionally set the "yarn.version" property if it 
is different from "hadoop.version". As of Spark 1.3, Spark only supports YARN 
versions 2.2.0 and later.
     
     Examples:
     
     {% highlight bash %}
     # Apache Hadoop 2.2.X
    -mvn -Pyarn -Phadoop-2.2 -Dhadoop.version=2.2.0 -DskipTests clean package
    +mvn -Pyarn -Phadoop-2.2 -Dhadoop.version=2.2.X -DskipTests clean package
     
     # Apache Hadoop 2.3.X
    -mvn -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0 -DskipTests clean package
    +mvn -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.X -DskipTests clean package
     
     # Apache Hadoop 2.4.X or 2.5.X
     mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=VERSION -DskipTests clean package
     
    +# Cloudera CDH 5.0.X
    +mvn -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0-cdh5.0.X -DskipTests clean 
package
    +
    +# Cloudera CDH 5.1.X
    +mvn -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0-cdh5.1.X -DskipTests clean 
package
    +
    +# Cloudera CDEH 5.2.X or 5.3.X
    --- End diff --
    
    This has a typo in "CDEH" and are also not runnable. I don't see much value 
in elaborating this example 3 more times.
    
    (As a related aside, I would like to see less, not more, vendor stuff in 
Spark anyway. Adding just this text unduly favors Cloudera a tiny bit; the 
alternative is to write a bunch of other vendor combos here, which is going to 
turn into at least a maintenance headache. I already disagree with maintaining 
vendor versioning info in the project POM.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to