cloud-fan commented on issue #24129: [SPARK-27190][SQL] add table capability for streaming URL: https://github.com/apache/spark/pull/24129#issuecomment-480709415 @rdblue I reverted the doc changes as you proposed because I want to get this in ASAP. I do agree with your concern about code conflicts when cherry-picking commits, and we should touch fewer files in a PR if possible. However, there is a trade-off here. When I review PRs, I'm ok with related document/comment changes that are non-functional(not must-have). It's good for the project development velocity as we can save the number of PRs(as well as the jenkins resource) for trivial improvements like typo fixes, simple doc/comment updates, etc. It's also easier to review if the code changes and related doc/comment updates are in the same PR. I'm not sure if there is an official policy for it, or it's simply a personal preference of the committer/reviewer? cc @srowen @felixcheung @dongjoon-hyun @gatorsmile
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
