gaborgsomogyi commented on a change in pull request #24270:
[SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10
URL: https://github.com/apache/spark/pull/24270#discussion_r272971069
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -456,11 +456,11 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
}
private[kafka010] object KafkaSourceProvider extends Logging {
- private val STRATEGY_OPTION_KEYS = Set("subscribe", "subscribepattern",
"assign")
+ private val STRATEGY_OPTION_KEYS = Set(SUBSCRIBE, SUBSCRIBE_PATTERN, ASSIGN)
private[kafka010] val STARTING_OFFSETS_OPTION_KEY = "startingoffsets"
private[kafka010] val ENDING_OFFSETS_OPTION_KEY = "endingoffsets"
private val FAIL_ON_DATA_LOSS_OPTION_KEY = "failondataloss"
- private val MIN_PARTITIONS_OPTION_KEY = "minpartitions"
+ private[kafka010] val MIN_PARTITIONS_OPTION_KEY = "minpartitions"
Review comment:
Since you've started to hide things (which is good) most of the params
around can be marked with `private[kafka010]` isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
