MaxGekk commented on issue #24316: [SPARK-27405][SQL][TEST] Restrict the range of generated random timestamps URL: https://github.com/apache/spark/pull/24316#issuecomment-480789776 > BTW, this PR is not tested ... because this reduces the range of generated data. > By DateExpressionsSuite in the PR #24311 I would agree the PR is not tested by an explicit test but what would you like to test? I think we can trust to ScalaCheck's `Gen.choose` that it returns longs in the range `[Long.MinValue / 1000, Long.MaxValue / 1000]`. There is theoretical foundation that generated milliseconds out of the range cause Long arithmetic overflow, so, the range cannot be wider. What should the test proof?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
