srowen commented on a change in pull request #24308: [SPARK-27397][Core] Take
care of OpenJ9 JVM in Spark
URL: https://github.com/apache/spark/pull/24308#discussion_r273245389
##########
File path:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java
##########
@@ -124,6 +124,9 @@ static JavaVendor getJavaVendor() {
if (vendorString.contains("OpenJDK")) {
return JavaVendor.OpenJDK;
}
+ if (vendorString.contains("OpenJ9")) {
Review comment:
Agree, you can delete the unused code here.
It looks like this was added to account for the fact that IBM JDKs don't
have a PermGen, but Spark no longer tries to set this now that Java 8 is
required and doesn't have a PermGen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
