cloud-fan commented on a change in pull request #24117: [SPARK-27181][SQL]: Add
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r273315422
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -65,6 +65,26 @@ class PlanResolutionSuite extends AnalysisTest {
}
}
+ test("create table - partitioned by transforms") {
+ val transforms = Seq(
+ "bucket(16, b)", "years(ts)", "months(ts)", "days(ts)", "hours(ts)",
"foo(a, 'bar', 34)",
+ "bucket(32, b), days(ts)")
Review comment:
this reminds me one thing: shall we resolve the references before passing
the transforms to the table catalog? Now we create transforms at parser side,
and we may pass `years(ts)` to the table catalog even if `ts` doesn't exist. Do
we expect the table catalog itself to resolve references?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
