cloud-fan commented on a change in pull request #24164: [SPARK-27225][SQL]
Implement join strategy hints
URL: https://github.com/apache/spark/pull/24164#discussion_r273345859
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
##########
@@ -71,21 +71,26 @@ object JoinHint {
case class HintInfo(strategy: Option[JoinStrategyHint] = None) {
/**
- * Combine two [[HintInfo]]s into one [[HintInfo]], in which the new
strategy will the strategy
- * in this [[HintInfo]] if defined, otherwise the strategy in the other
[[HintInfo]].
+ * Combine this [[HintInfo]] with another [[HintInfo]] and return the new
[[HintInfo]].
+ * @param other the other [[HintInfo]]
+ * @param hintOverriddenCallback a callback to notify if any [[HintInfo]]
has been overridden
Review comment:
if we create a hint merging strategy framework, I think it will not be an
arbitrary callback. Shall we make it simple now and leave it for future design?
Then we can just log message inside this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
