cloud-fan commented on a change in pull request #24321: [SPARK-27411][SQL]
DataSourceV2Strategy should not eliminate subquery
URL: https://github.com/apache/spark/pull/24321#discussion_r273351430
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -106,13 +106,16 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
case PhysicalOperation(project, filters, relation: DataSourceV2Relation) =>
val scanBuilder = relation.newScanBuilder()
+ val (withSubquery, withoutSubquery) =
filters.partition(SubqueryExpression.hasSubquery)
val normalizedFilters = DataSourceStrategy.normalizeFilters(
- filters.filterNot(SubqueryExpression.hasSubquery), relation.output)
+ withoutSubquery, relation.output)
// `pushedFilters` will be pushed down and evaluated in the underlying
data sources.
// `postScanFilters` need to be evaluated after the scan.
// `postScanFilters` and `pushedFilters` can overlap, e.g. the parquet
row group filter.
- val (pushedFilters, postScanFilters) = pushFilters(scanBuilder,
normalizedFilters)
+ val (pushedFilters, postScanFiltersWithoutSubquery) =
+ pushFilters(scanBuilder, normalizedFilters)
+ val postScanFilters = postScanFiltersWithoutSubquery ++ withSubquery
val (scan, output) = pruneColumns(scanBuilder, relation, project ++
postScanFilters)
Review comment:
nit: we can make it more clear
```
val (pushedFilters, postScanFilters) = pushFilters(scanBuilder,
normalizedFilters)
val (scan, output) = pruneColumns(scanBuilder, relation, project ++
postScanFilters ++ withSubquery)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
