Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3739#issuecomment-68078117
It looks like most of the tests that modify system properties only do so
because they were written prior to the introduction of SparkConf. I'm going to
see how many of these can be refactored to use SparkConf instead. I think
we'll still need the fixture to handle a couple of tests that specifically deal
with reading from system properties (such as the tests of SparkConf itself),
but hopefully this will remove most of hte complexity and let us use this trait
sparingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
