srowen commented on a change in pull request #24312: [SQL] Unnecessary access
to externalCatalog
URL: https://github.com/apache/spark/pull/24312#discussion_r273490373
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -1105,10 +1105,16 @@ class SessionCatalog(
* Check if the function with the specified name exists
*/
def functionExists(name: FunctionIdentifier): Boolean = {
- val db = formatDatabaseName(name.database.getOrElse(getCurrentDatabase))
- requireDbExists(db)
- functionRegistry.functionExists(name) ||
Review comment:
I think this is OK too though a little exotic - the current form is OK. You
can get rid of the 'else' clause for more simplicity in the current change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
