dongjoon-hyun commented on a change in pull request #24318: [SPARK-27407][SQL]
File source V2: Invalidate cache data on overwrite/append
URL: https://github.com/apache/spark/pull/24318#discussion_r273570174
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -494,6 +494,38 @@ class FileBasedDataSourceSuite extends QueryTest with
SharedSQLContext with Befo
}
}
+ test("Do not use cache on overwrite") {
+ Seq("", "orc").foreach { useV1SourceReaderList =>
+ withSQLConf(SQLConf.USE_V1_SOURCE_READER_LIST.key ->
useV1SourceReaderList) {
+ withTempDir { dir =>
+ val path = dir.toString
+ spark.range(1000).write.mode("overwrite").orc(path)
Review comment:
If that is the logic, let's hold on this until Parquet is ready to migrate.
We don't need to move around the test logic from here to there.
We are going to migrate Parquet anyway, aren't we?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
