rdblue commented on a change in pull request #24117: [SPARK-27181][SQL]: Add 
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r273549628
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
 ##########
 @@ -65,6 +65,26 @@ class PlanResolutionSuite extends AnalysisTest {
     }
   }
 
+  test("create table - partitioned by transforms") {
+    val transforms = Seq(
+        "bucket(16, b)", "years(ts)", "months(ts)", "days(ts)", "hours(ts)", 
"foo(a, 'bar', 34)",
+        "bucket(32, b), days(ts)")
 
 Review comment:
   Spark will validate that the columns exist in the table schema using an 
analysis rule. That isn't going into this PR. This PR updates the parser and 
adds tests for that. We will add analysis rules later, when this PR makes it in.
   
   The reason why we can't add them here is that we don't want to write 
validations against the parsed SQL plans. We want to write them against the v2 
create table commands, which won't be added until after the table catalog makes 
it in (#24246).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to