Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3687#discussion_r22265904
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/TestSuiteBase.scala ---
    @@ -104,6 +106,77 @@ class TestOutputStreamWithPartitions[T: 
ClassTag](parent: DStream[T],
     }
     
     /**
    + * This is an interface that can be used to block until certain events 
occur, such as
    + * the start/completion of batches.  This is much less brittle than 
waiting on wall-clock time.
    + * Internally, this is implemented using a StreamingListener.  
Constructing a new instance of this
    + * class automatically registers a StreamingListener on the given 
StreamingContext.
    + */
    +class StreamingTestWaiter(ssc: StreamingContext) {
    +
    +  // All access to this state should be guarded by 
`StreamingListener.this.synchronized`
    --- End diff --
    
    Yep, good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to