dongjoon-hyun commented on a change in pull request #24315: [SPARK-27403][SQL] 
Table Statisics shall be updated automatically if auto size update feature is 
enabled(spark.sql.statistics.size.autoUpdate.enabled =true)
URL: https://github.com/apache/spark/pull/24315#discussion_r273734782
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala
 ##########
 @@ -337,6 +337,22 @@ class StatisticsCollectionSuite extends 
StatisticsCollectionTestBase with Shared
     }
   }
 
+  test("auto gather stats after insert command") {
+    val table = "change_stats_insert_datasource_table"
+    val autoUpdate = true
+      withSQLConf(SQLConf.AUTO_SIZE_UPDATE_ENABLED.key -> autoUpdate.toString) 
{
 
 Review comment:
   Thank you for updating, @sujith71955 . Here are two issues.
   1. We need to test both cases by using `Seq(false, true).foreach { 
autoUpdate =>`
   2. The current indentation is wrong at 343.
   
   If you fix (1), (2) will be fixed together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to