mgaido91 commented on a change in pull request #21502: [SPARK-22575][SQL] Add 
destroy to Dataset
URL: https://github.com/apache/spark/pull/21502#discussion_r273963948
 
 

 ##########
 File path: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
 ##########
 @@ -288,6 +288,9 @@ private[hive] class SparkExecuteStatementOperation(
     if (statementId != null) {
       sqlContext.sparkContext.cancelJobGroup(statementId)
     }
+    if (result != null) {
+      result.destroy()
 
 Review comment:
   because an approach like the one proposed here 
https://github.com/apache/spark/pull/21502#issuecomment-397799870 is better, 
but I had no time to try it (and I also have a limited knowledge of that area 
of Spark). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to