srowen commented on a change in pull request #24302: [SPARK-27392][SQL]
TestHive test tables should be placed in shared test state, not per session
URL: https://github.com/apache/spark/pull/24302#discussion_r273969434
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -480,14 +484,12 @@ private[hive] class TestHiveSparkSession(
hiveQTestUtilTables.foreach(registerTestTable)
}
- private val loadedTables = new collection.mutable.HashSet[String]
-
- def getLoadedTables: collection.mutable.HashSet[String] = loadedTables
+ def getLoadedTables: collection.mutable.HashSet[String] =
sharedState.loadedTables
def loadTestTable(name: String) {
- if (!(loadedTables contains name)) {
+ if (!(sharedState.loadedTables contains name)) {
Review comment:
PS I wouldn't mind avoiding postfix notation here. I'm trying to remove it
from the code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
