srowen commented on a change in pull request #23856: [SPARK-26953][CORE][TEST]
Test TimSort for ArrayIndexOutOfBoundsException
URL: https://github.com/apache/spark/pull/23856#discussion_r274198187
##########
File path:
core/src/test/scala/org/apache/spark/util/collection/SorterSuite.scala
##########
@@ -74,6 +74,103 @@ class SorterSuite extends SparkFunSuite with Logging {
(0 to data.length - 2).foreach(i => assert(data(i) <= data(i + 1)))
}
+ test("java.lang.ArrayIndexOutOfBoundsException in TimSort") {
Review comment:
I'm OK with that. Checking correctness is nice but it's costly given how
huge the array is. I think we already tried to optimize it. Other tests are
evaluating correctness of the sort, so kinda OK to not do that here too. That
said I don't know how much removing that check helps? worth trying
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
