Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/3726#discussion_r22267308
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -139,14 +139,22 @@ private[streaming] class ReceivedBlockTracker(
getReceivedBlockQueue(streamId).toSeq
}
- /** Clean up block information of old batches. */
+ /** Clean up block information of old batches asynchronously. */
def cleanupOldBatches(cleanupThreshTime: Time): Unit = synchronized {
+ cleanupOldBatches(cleanupThreshTime, waitForCompletion = false)
+ }
+
+ /**
+ * Clean up block information of old batches. If waitForCompletion is
true, this method
+ * returns only after the files are cleaned up.
+ */
+ def cleanupOldBatches(cleanupThreshTime: Time, waitForCompletion:
Boolean): Unit = synchronized {
--- End diff --
Hmm..I thought I pushed the commit that removed this one. Let me check.
Anyway I agree we don't need both, will remove the other one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
