Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3784#discussion_r22267605
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -348,6 +349,37 @@ object CombineFilters extends Rule[LogicalPlan] {
}
/**
+ * Normalizes conjunctions and disjunctions to eliminate common factors.
+ */
+object NormalizeFilters extends Rule[LogicalPlan] with PredicateHelper {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case f @ Filter(predicate: Predicate, child) =>
--- End diff --
`f.transformExpressionUp` instead? And this rule can also apply to the
normal expressions, other than only for expression in `Filter`. Move this into
`BooleanSimplification`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
