MaxGekk commented on issue #24343: [SPARK-26953][CORE][TEST] Disable result checking in the test: java.lang.ArrayIndexOutOfBoundsException in TimSort URL: https://github.com/apache/spark/pull/24343#issuecomment-482095056 > Would not it be better simply just remove those lines along with the comment? @attilapiros Let's consider a situation when somebody made a changes in TimSort, and the test failed. You fixed TimSort, run the test and it does not crash, but you want to be sure that results of sorting are correct as well. So, you can just re-use the existing code instead of writing it again (or digging into history if you know the checking code existed before).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
