rdblue commented on a change in pull request #24246: [SPARK-24252][SQL] Add 
TableCatalog API
URL: https://github.com/apache/spark/pull/24246#discussion_r274596428
 
 

 ##########
 File path: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/expressions/Expressions.java
 ##########
 @@ -96,7 +96,7 @@ public Transform bucket(int numBuckets, String... columns) {
    * @param column an input column
    * @return a logical identity transform with name "identity"
    */
-  public Transform identity(String column) {
+  public static Transform identity(String column) {
 
 Review comment:
   Fixing these methods that should have been static is required here: 
https://github.com/apache/spark/pull/24246/files#diff-d921fee79b4e63ab684dec9d10afeb44R63.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to