gatorsmile commented on issue #24352: [SPARK-27199][SQL][FOLLOWUP] Fix bug in codegen templates in UnixTime and FromUnixTime URL: https://github.com/apache/spark/pull/24352#issuecomment-482347705 In general, I have to say the test coverage is not good. After we reduce the total test time, I plan to suggest porting more end-to-end tests from the other open source SQL engine. When reviewing the changes, we need to encourage the community to add more tests and the reviewers also need to spend more time to check all the code paths are covered by the tests; otherwise, it is easy to be broken by the future code changes. I am not sure how the other committers are reviewing the code. For me, it is very time consuming in the code review. We normally downloaded the code, play with the changes and run them in our local environment. I will try to allocate more time in the code review in the future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
