srowen commented on issue #24352: [SPARK-27199][SQL][FOLLOWUP] Fix bug in codegen templates in UnixTime and FromUnixTime URL: https://github.com/apache/spark/pull/24352#issuecomment-482354146 Yep, +1 to more tests, but as you say, it's a question of effort. I think that if we implement the standard you're suggesting, we'd merge very little, and that has its own costs. We're already not able to review even most of the open PRs. On the meta-issue here: I don't think anybody disagrees with "be careful" but it's always a judgment call: how _likely_ is this to cause a problem of what size? compared to the benefit of not doing it? too eager and we'll introduce bugs, too conservative and we'll miss important fixes and changes. We can all only make our best-effort guess. You are an important voice for being conservative; I'm only saying it's not as simple as others being uncareful. Anyway yeah let's get this fix in of course. It's great that there are downstream tests making additional checks, at least, after the fact.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
