xuanyuanking commented on issue #24350: [SPARK-27348][Core] HeartbeatReceiver should remove lost executors from CoarseGrainedSchedulerBackend URL: https://github.com/apache/spark/pull/24350#issuecomment-482425867 @attilapiros Great thanks for your review. ``` the test I just realised there is a resource leak as FakeSchedulerBackend is not stopped ``` Yeah, done in a933d0a. ``` Oh there must be a race condition as this test was running at my side locally, on the other hand your change contradicts https://issues.apache.org/jira/browse/SPARK-8119. ``` Yes, that's also why UT failed the first time, we should add the logic after `sc.killAndReplaceExecutor`. Also done in a933d0a.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
