cloud-fan commented on a change in pull request #24358: [SPARK-27449] Move
WholeStageCodegen.limitNotReachedCond class checks into separate methods.
URL: https://github.com/apache/spark/pull/24358#discussion_r274878499
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
##########
@@ -426,6 +430,9 @@ trait BlockingOperatorWithCodegen extends CodegenSupport {
// that upstream operators will not generate useless conditions (which are
always evaluated to
// false) for the Limit operators after this blocking operator.
override def limitNotReachedChecks: Seq[String] = Nil
+
+ // This is a blocking node so the node cna produce these checks
Review comment:
nit: `cna` -> `can`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
