skonto commented on a change in pull request #23546: [SPARK-23153][K8s] Support
client dependencies with a Hadoop Compatible File System
URL: https://github.com/apache/spark/pull/23546#discussion_r274878391
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala
##########
@@ -112,7 +112,12 @@ private[spark] object Minikube extends Logging {
private def executeMinikube(action: String, args: String*): Seq[String] = {
ProcessUtils.executeProcess(
- Array("bash", "-c", s"minikube $action") ++ args,
MINIKUBE_STARTUP_TIMEOUT_SECONDS)
+ Array("bash", "-c", s"minikube $action ${args.mkString(" ")}"),
Review comment:
there was a bug here as args beyond the action were not grouped together and
so they were ignored at execution time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
