hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-482570405 @gaborgsomogyi Hi, I have delete the variable of `MIN_PARTITIONS ` that is useless . ```scala private[kafka010] object KafkaOffsetRangeCalculator { def apply(options: CaseInsensitiveStringMap): KafkaOffsetRangeCalculator = { val optionalValue = Option(options.get("minPartitions")).map(_.toInt) new KafkaOffsetRangeCalculator(optionalValue) } } ``` The master branch uses "minPartitions", but get operation uses lowercase conversion. So I use `KafkaSourceProvider.MIN_PARTITIONS_OPTION_KEY`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
