srowen commented on a change in pull request #24366: [MINOR] Fix import in
NettyStreamManager.scala
URL: https://github.com/apache/spark/pull/24366#discussion_r275135820
##########
File path:
core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala
##########
@@ -58,7 +59,7 @@ private[netty] class NettyStreamManager(rpcEnv: NettyRpcEnv)
new File(dir, fname)
}
- if (file != null && file.isFile()) {
+ if (file != null && file.isFile) {
Review comment:
While these changes are still correct behavior-wise, these are java methods
that are defines as zero-arg methods, so including parens is a little more
correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
