HyukjinKwon commented on a change in pull request #24354: [SPARK-25348][SQL] Data source for binary files URL: https://github.com/apache/spark/pull/24354#discussion_r275147059
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileSuite.scala ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.datasources.binaryfile + +import java.sql.Timestamp + +import com.google.common.io.{ByteStreams, Closeables} +import org.apache.hadoop.fs.{GlobFilter, Path} + +import org.apache.spark.sql.{QueryTest, Row} +import org.apache.spark.sql.functions.col +import org.apache.spark.sql.test.{SharedSQLContext, SQLTestUtils} + +class BinaryFileSuite extends QueryTest with SharedSQLContext with SQLTestUtils { + + private lazy val filePath = testFile("test-data/binaryfile-partitioned") Review comment: Can we write test files only for testing time to avoid adding unnesseary binary files into our code base and make it easier to read? For instance, for binary, ```scala val tempDir = Utils.createTempDir() val testFile = new File(dir, "part-00000") Files.write(binary, testFile) ``` For csv, text ``` df.write.[csv|text](...) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
