felixcheung commented on a change in pull request #24365: [SPARK-27453] Pass
partitionBy as options in DataFrameWriter
URL: https://github.com/apache/spark/pull/24365#discussion_r275168812
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1687,6 +1687,15 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_PASS_PARTITION_BY_AS_OPTIONS =
+ buildConf("spark.sql.legacy.sources.write.passPartitionByAsOptions")
+ .internal()
+ .doc("Whether to pass the partitionBy columns as options in
DataFrameWriter." +
+ " Data source V1 now silently drops partitionBy columns for
non-file-format sources;" +
+ " turning the flag on provides a way for these sources to see these
partitionBy columns.")
+ .booleanConf
+ .createWithDefault(true)
Review comment:
shouldn't the default be `false` to be backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
