Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3778#discussion_r22277093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -112,7 +112,30 @@ case class InSet(value: Expression, hset: Set[Any])
}
}
-case class And(left: Expression, right: Expression) extends
BinaryPredicate {
+abstract class CombinePredicate extends BinaryPredicate {
--- End diff --
Since we already have the `implicit` class in `Optimizer`, I don't really
think we should make the existed expression more complicated. And probably even
the `CombinePredicate` is not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
