squito commented on a change in pull request #24375: [SPARK-25250][CORE] try
best to not submit tasks when the partitions are already completed
URL: https://github.com/apache/spark/pull/24375#discussion_r275517165
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -819,12 +816,9 @@ private[spark] class TaskSetManager(
maybeFinishTaskSet()
}
- private[scheduler] def markPartitionCompleted(partitionId: Int, taskInfo:
TaskInfo): Unit = {
+ private[scheduler] def markPartitionCompleted(partitionId: Int): Unit = {
partitionToIndex.get(partitionId).foreach { index =>
if (!successful(index)) {
- if (speculationEnabled && !isZombie) {
- successfulTaskDurations.insert(taskInfo.duration)
- }
Review comment:
I'm undecided about this part of the change in general (I see an argument
for doing it both ways) but I'd still prefer it is not in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
