cloud-fan commented on a change in pull request #24375: [SPARK-25250][CORE] try
best to not submit tasks when the partitions are already completed
URL: https://github.com/apache/spark/pull/24375#discussion_r275612842
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -819,12 +816,9 @@ private[spark] class TaskSetManager(
maybeFinishTaskSet()
}
- private[scheduler] def markPartitionCompleted(partitionId: Int, taskInfo:
TaskInfo): Unit = {
+ private[scheduler] def markPartitionCompleted(partitionId: Int): Unit = {
partitionToIndex.get(partitionId).foreach { index =>
if (!successful(index)) {
- if (speculationEnabled && !isZombie) {
- successfulTaskDurations.insert(taskInfo.duration)
- }
Review comment:
then how about we use `0` as the task duration here? There is no `taskInfo`
so I have to update this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
