cloud-fan commented on a change in pull request #24371: 
[SPARK-27176][FOLLOW-UP][SQL] Shade Parquet to sql/core
URL: https://github.com/apache/spark/pull/24371#discussion_r275652735
 
 

 ##########
 File path: sql/hive/pom.xml
 ##########
 @@ -56,6 +56,12 @@
       <groupId>org.apache.spark</groupId>
       <artifactId>spark-sql_${scala.binary.version}</artifactId>
       <version>${project.version}</version>
+      <exclusions>
 
 Review comment:
   If we don't exclude it, then the hive module will depend on a shaded parquet 
lib, right?
   
   Assuming it's not excluded, then the hive module depends on both the shaded 
parquet, and the standard parquet that is brought by the hive lib. Does it 
cause any problem?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to