squito commented on a change in pull request #23767: [SPARK-26329][CORE] Faster
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r275865092
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -557,13 +583,13 @@ private[spark] class Executor(
setTaskFinishedAndClearInterruptStatus()
execBackend.statusUpdate(taskId, TaskState.FINISHED, serializedResult)
-
} catch {
case t: TaskKilledException =>
logInfo(s"Executor killed $taskName (TID $taskId), reason:
${t.reason}")
val (accums, accUpdates) =
collectAccumulatorsAndResetStatusOnFailure(taskStartTimeNs)
- val serializedTK = ser.serialize(TaskKilled(t.reason, accUpdates,
accums))
+ val metricPeaks =
WrappedArray.make(metricsPoller.getTaskMetricPeaks(taskId))
+ val serializedTK = ser.serialize(TaskKilled(t.reason, accUpdates,
accums, metricPeaks))
Review comment:
I think its worth a brief comment on why you're using `WrappedArray`, eg.
"put metrics in a WrappedArray to expose as a Seq without requiring a copy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
