kiszk commented on a change in pull request #24392:
[SPARK-27423][SQL][FOLLOWUP] Minor polishes to Cast codegen templates for Date
<-> Timestamp
URL: https://github.com/apache/spark/pull/24392#discussion_r276140944
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1028,7 +1029,7 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
from: DataType,
ctx: CodegenContext): CastFunction = from match {
case StringType =>
- val zid = ctx.addReferenceObj("zoneId", zoneId, "java.time.ZoneId")
+ val zid = ctx.addReferenceObj("zoneId", zoneId, classOf[ZoneId].getName)
Review comment:
super nit: From the consistency view, I am curious that only this statement
is not wrapped by `JavaCode.global`.
Of course, it is not a big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
