Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3778#issuecomment-68178485
@scwf Two comments about your new branch:
1. `ConditionSimplification` is actually a synonym of
`BooleanSimplification`. The latter also covers simple cases of `And` / `Or`
expressions since `And` / `Or` *are* themselves boolean expressions. Thus these
two can be naturally merged together.
2. Would like to add that, compared to optimizing cartesian product to
equi-join, benefits brought by numeric comparison optimizations are very
limited. Even in the best cases, they can only optimize out some O(1)
comparisons, which are practically very cheap. Personally I don't think this
worth the effort to either introduce an extra library dependency (which
increases risks of dependency hell) or write complicated code that implements
them (which increases maintenance costs). The low benefit-cost ratio makes I
feel hesitant to include them.
(As for the floating point precision part, after rethinking this, I feel
it's generally safe since we are only casting literal numeric values to double
without further computations.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
